Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resubmit to Nature Methods #254

Closed
mdhaber opened this issue Sep 19, 2019 · 14 comments
Closed

Resubmit to Nature Methods #254

mdhaber opened this issue Sep 19, 2019 · 14 comments

Comments

@mdhaber
Copy link
Contributor

mdhaber commented Sep 19, 2019

Suggested plan:

  1. @tylerjereddy Merge Rebuttal letter #248 if it looks good (aside from not mentioning bibliography changes)
  2. @tylerjereddy Generate final latexdiff PDF
  3. @mdhaber add bibliography changes to that PDF manually
  4. @mdhaber @tylerjereddy @rgommers add signature to rebuttal letter
  5. @tylerjereddy Resubmit

Does that sound good? @tylerjereddy that looks a little heavy on your end but I imagine #2 is easy since you've already been working with it.

@tylerjereddy
Copy link
Contributor

First one is done anyway

@stefanv
Copy link
Member

stefanv commented Sep 19, 2019

Thank you for all your work on this, @tylerjereddy and @mdhaber.

@tylerjereddy
Copy link
Contributor

I'm adjusting the results from raw latexdiff on the two bbl files Matt linked in #248--the changes get commented out by default in many places because of the interference of bibtex commands. We'll see how far I get..

@mdhaber
Copy link
Contributor Author

mdhaber commented Sep 19, 2019

@tylerjereddy if it's not easy to edit the source, I was just going to edit manually in Adobe Acrobat.

@tylerjereddy
Copy link
Contributor

Ok, I made a repo for additional latexdiff refinements and the result is working pretty well for the references in a scripted manner now:
diff-paper.pdf

There are still opportunities to improve it, but time... does it look ok for refs?

I patched up Table 1 to fit on the page, but at some cost--the diffs for the references at the bottom of that table were removed--I think those were nearly useless though, esp. with the overflow.

Things that could be better on the diff PDF include some extra whitespace (esp. around some optimize sections) & the references could still be a little more robust, but I think it is relatively clear even if some URLs don't get fully underlined, etc.

@mdhaber
Copy link
Contributor Author

mdhaber commented Sep 19, 2019

Wow, I think that's terrific. Not a big deal, but do you know why it missed the changes to the top author list but noted the changes to the consortium?

@charris
Copy link
Member

charris commented Sep 19, 2019

The reviewer mail mentioned that corresponding authors need an ORCID id. Does that mean all of us mentioned as authors should go to the website and follow the link? Since that information is confidential to the core-dev list, it would be useful to post the procedure if it is required.

@tylerjereddy
Copy link
Contributor

The reviewer mail mentioned that corresponding authors need an ORCID id. Does that mean all of us mentioned as authors should go to the website and follow the link? Since that information is confidential to the core-dev list, it would be useful to post the procedure if it is required.

I think that's just Matt, Ralf & I (3 was the max allowed). I actually don't think even Matt & Ralf had a way to add their ORCID--perhaps I can ask politely if any others can have a way to add theirs.

@tylerjereddy
Copy link
Contributor

but do you know why it missed the changes to the top author list but noted the changes to the consortium?

Looking at the source, there are just plain DIF tags on the main author list because it is a command that happens before \begin{document}. There's a special preamble that gets added for latexdiff commands--I've tried shifting that prior to the title, but so far it doesn't like using latexdiff commands before the doc proper starts.

@tylerjereddy
Copy link
Contributor

Maybe we could highlight those just in color or something manually? The repo is linked above if you want to see the plain linux diff tags on the main author list.

Alternatively, we may need to put the commands in a style file or something that is providing the title command, not sure.

@mdhaber
Copy link
Contributor Author

mdhaber commented Sep 20, 2019

I'll take a look, but IIRC I think somebody added an affiliation and consequently some numbers shuffled around. Since that's even less significant than the bibliography changes, I think we should just ignore it without mentioning it.

@tylerjereddy
Copy link
Contributor

Ok, if you give me the green light I'll sign the letter & use the most recent PDF above

@mdhaber
Copy link
Contributor Author

mdhaber commented Sep 20, 2019

Yes, that was the only change to the top author list, so go for it.

@mdhaber
Copy link
Contributor Author

mdhaber commented Sep 22, 2019

Resubmitted by @tylerjereddy. Thanks!

@mdhaber mdhaber closed this as completed Sep 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants