Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more lazy definition of primitive R functions #95

Open
behrica opened this issue May 7, 2024 · 5 comments
Open

more lazy definition of primitive R functions #95

behrica opened this issue May 7, 2024 · 5 comments

Comments

@behrica
Copy link
Member

behrica commented May 7, 2024 •
edited
Loading

These type of def

clojisr/src/clojisr/v1/r.clj

Line 127 in f42566f

(def r== (r "`==`"))

make R to get initialised on loading the ns which is "bad practice".
Ideally a ns loading should "do nothing".

It might be possible to change all of them to a function:

(defn r== [e1 e2] ((clojisr.v1.r/r "`==`") e1 e2))
@behrica
Copy link
Member Author

behrica commented May 7, 2024

Needed to be solved to get cljdoc on CI server working:
see #94

@behrica behrica mentioned this issue May 7, 2024
Open
@behrica
Copy link
Member Author

behrica commented May 7, 2024

I will give this a try and make a PR

@behrica
Copy link
Member Author

behrica commented May 7, 2024

For the simple functions "r_xx" it looks good. Not sure I manage the bra macros

@behrica
Copy link
Member Author

behrica commented May 7, 2024

PR #99 has been started

@behrica
Copy link
Member Author

behrica commented May 7, 2024

PR #99 is ready for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@behrica