-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What are the returns from fit_im? #9
Comments
Thanks for looking at this.
|
Great, thanks! Shall we leave this open until you get a chance to put this into the documentation somewhere? |
Yes, I'll leave it open as a reminder that I should add some docstrings for functions---certainly at least some of the major entrance points. |
I will say that I also had to explain this to someone in the last 3 months, so it is a high priority doc string. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Could you provide some narrative documentation for the returns from fit_im?
crowdsource/crowdsource/crowdsource_base.py
Lines 695 to 696 in d0bb2eb
My attempt:
stars
is the star catalogmodel + sky
is the sum of the stellar model and the "background" modelsky + msky
is the .... sky model? It's low-resolution. I'm not sure how to differentiatesky
,msky
, andmodel
, though I suspectmodel
is the stars-only image?psf
is the fitted PSF (or the original PSF if refitting isn't used)Which return value would you consider the best representation of the star-subtracted image? i.e., the best representation of the extended emission?
The text was updated successfully, but these errors were encountered: