Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing FontAwesome Modules when using core-ui as dependency #300

Open
Cuervino opened this issue Apr 15, 2021 · 0 comments
Open

Missing FontAwesome Modules when using core-ui as dependency #300

Cuervino opened this issue Apr 15, 2021 · 0 comments
Assignees
Labels
bug Something isn't working priority:medium Medium priority issues, should only be postponed if no other option

Comments

@Cuervino
Copy link
Contributor

Cuervino commented Apr 15, 2021

Component:
Icon.component.js

What happened:
Missing 2 modules when core-ui used as a dependency

  • @fortawesome/react-fontawesome
  • @fortawesome/fontawesome-svg-core
ERROR in ./node_modules/@fortawesome/react-fontawesome/index.es.js
Module not found: Error: Can't resolve '@fortawesome/fontawesome-svg-core' in 'git\zenko-ui\node_modules\@fortawesome\react-fontawesome'
 @ ./node_modules/@fortawesome/react-fontawesome/index.es.js 1:0-64 263:6-11 264:11-16 318:83-88 320:21-25
 @ ./node_modules/@scality/core-ui/dist/components/icon/Icon.component.js
 @ ./node_modules/@scality/core-ui/dist/index.js
 @ ./src/react/ZenkoUI.js
 @ ./src/react/App.js

Solved when I installed those 2 modules.

Note that then, the loaded assets size could increase too much.

@Cuervino Cuervino added bug Something isn't working priority:medium Medium priority issues, should only be postponed if no other option labels Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority:medium Medium priority issues, should only be postponed if no other option
Projects
None yet
Development

No branches or pull requests

2 participants