Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some components did not set the color correctly #284

Open
ChengYanJin opened this issue Mar 30, 2021 · 1 comment
Open

Some components did not set the color correctly #284

ChengYanJin opened this issue Mar 30, 2021 · 1 comment
Assignees
@alexis-ld
Labels
bug Something isn't working priority:medium Medium priority issues, should only be postponed if no other option

Comments

@ChengYanJin
Copy link
Contributor

Component:sidebar, tabs, healthselector, no-row table

What happened:
image
image

What was expected:

Steps to reproduce

Resolution proposal (optional):
@ChengYanJin ChengYanJin added the bug Something isn't working label Mar 30, 2021
@ChengYanJin ChengYanJin added the priority:medium Medium priority issues, should only be postponed if no other option label Mar 30, 2021
@theocerutti
Copy link
Contributor

theocerutti commented Apr 6, 2021 •
edited
Loading

@ChengYanJin Hello! I looked on the core-ui storybook and I don't have any issue. (every components colors are set correctly)

Edit: Now some colors of the light theme are not set correctly because the darkRebrand theme have colors that light theme doesn't have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexis-ld alexis-ld

Labels
bug Something isn't working priority:medium Medium priority issues, should only be postponed if no other option
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexis-ld @ChengYanJin @theocerutti