Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create wrapper for the dashed-line chart from vega-lite #224

Open
ChengYanJin opened this issue Jan 27, 2021 · 0 comments
Open

Create wrapper for the dashed-line chart from vega-lite #224

ChengYanJin opened this issue Jan 27, 2021 · 0 comments
Labels
enhancement New feature or request priority:low Low priority issues that can be safely postponed if needed question Further information is requested

Comments

@ChengYanJin
Copy link
Contributor

ChengYanJin commented Jan 27, 2021 •
edited by thomasdanan
Loading

Component: linechart

Why this is needed:
We have a new use case of linechart with dashed line to display the average. we should create a wrapper here in core-ui to reuse the component.

comparison-05-03-v5-metrics-avg-on-variant4-ON-popup@2x

What should be done:

Implementation proposal (strongly recommended):

Test plan:
@ChengYanJin ChengYanJin added the enhancement New feature or request label Jan 27, 2021
@thomasdanan thomasdanan added question Further information is requested priority:low Low priority issues that can be safely postponed if needed labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request priority:low Low priority issues that can be safely postponed if needed question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ChengYanJin @thomasdanan