Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MultiDict and MultiSet should be either abstract traits or concrete implementations #25

Open
joshlemer opened this issue Jul 3, 2019 · 1 comment
Open

MultiDict and MultiSet should be either abstract traits or concrete implementations #25

joshlemer opened this issue Jul 3, 2019 · 1 comment

Comments

@joshlemer
Copy link
Contributor

joshlemer commented Jul 3, 2019 •
edited
Loading

Currently the pattern between MultiDicts and MultiSets are different:

  • MultDict is a concrete collection
  • MultiSet is an abstract data type (trait) with a public concrete implementation MultiSetImpl.

I lean more towards the abstract data type approach of MultiSet, since it is consistent with the rest of the collections. Though the name MultiSetIml/BagImpl isn't very good. Perhaps CountedMultiSet/CountedBag extends MultiSet/Bag?
@joshlemer joshlemer changed the title Consistency {col/imm/mut}.MultiDict and MultiSet as either abstract traits or concrete implementations Consistency MultiDict and MultiSet as either abstract traits or concrete implementations Jul 3, 2019
@julienrf
Copy link
Collaborator

julienrf commented Jul 4, 2019

If the intermediate trait is not needed or useful, I would remove it.

@joshlemer joshlemer mentioned this issue Jun 30, 2020
Open
@joshlemer joshlemer changed the title Consistency MultiDict and MultiSet as either abstract traits or concrete implementations MultiDict and MultiSet should be either abstract traits or concrete implementations Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@julienrf @joshlemer