You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
TL;DR: if scala-steward could source a script before running sbt, repositories could set up any auth tokens or other things necessary for the build to succeed
The poolq build currently uses the sbt-github-packages plugin to configure publishing to GitHub packages. That plugin requires some configuration in order to function and it's somewhat awkward in SBT to stub out or delay the initialization of those things, even though they're not needed by sbt in order to run the basic tests for the repository. In short, scala-steward shouldn`t care but due to limitations in the plugin, it ends up needing to in a way that's rather hard to avoid.
My suggestion is that if scala-steward had a way to run some sort of shell script in advance of running sbt test, a repository could put in place configuration settings that were necessary for the build to succeed, and putting control in the hands of the repository hopefully would allow the solution to be more general than simply setting a dummy GITHUB_TOKEN for repositories that happened to use GitHub packages.
I'd be interested in contributing such a feature, but I wanted to discuss a possible solution here before attempting anything.
The text was updated successfully, but these errors were encountered:
Since Scala build tools (sbt, mill, etc) supports credential configuration, I think credentials should be configured in build tools (sbt, mill, etc) at user side.
I do not find a good justification for Scala Steward to run shell script just for configuring dummy credential.
If missing credentials affect Scala Steward, I think other tools such as running Scalafix in GitHub Action are also affected.
If credentials is configured properly in build tool, not only Scala Steward but other tools are happy.
TL;DR: if scala-steward could source a script before running
sbt
, repositories could set up any auth tokens or other things necessary for the build to succeedBased on discussion here.
The poolq build currently uses the sbt-github-packages plugin to configure publishing to GitHub packages. That plugin requires some configuration in order to function and it's somewhat awkward in SBT to stub out or delay the initialization of those things, even though they're not needed by
sbt
in order to run the basic tests for the repository. In short,scala-steward
shouldn`t care but due to limitations in the plugin, it ends up needing to in a way that's rather hard to avoid.My suggestion is that if
scala-steward
had a way to run some sort of shell script in advance of runningsbt test
, a repository could put in place configuration settings that were necessary for the build to succeed, and putting control in the hands of the repository hopefully would allow the solution to be more general than simply setting a dummyGITHUB_TOKEN
for repositories that happened to use GitHub packages.I'd be interested in contributing such a feature, but I wanted to discuss a possible solution here before attempting anything.
The text was updated successfully, but these errors were encountered: