Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pnpm instead of yarn #290

Closed
darrylyeo opened this issue Apr 7, 2023 · 7 comments
Closed

Use pnpm instead of yarn #290

darrylyeo opened this issue Apr 7, 2023 · 7 comments
Labels
waiting Can't start working on the issue (it has dependencies)

Comments

@darrylyeo
Copy link

darrylyeo commented Apr 7, 2023

pnpm supports monorepos like yarn and comes with benefits like faster npm package install times and a content-addressable storage that saves disk space. It'll be a huge time-saver for devs who work with lots of codebases and/or Scaffold-Eth-2 forks that share lots of dependencies.

@sverps
Copy link
Collaborator

sverps commented Apr 8, 2023

Hey @darrylyeo, thanks for the suggestion.

I don't have a strong preference for either, but I think it's probably not worth it to switch now. The difference with yarn v2 is minimal, and users are now already familiar with that since the previous scaffold-eth also used it.

Maybe it would be nice to give some package manager options in the npx create tool we're thinking to implement (#251), but this will probably remain rather low prio.

@technophile-04 technophile-04 added the waiting Can't start working on the issue (it has dependencies) label Apr 12, 2023
@schmidsi
Copy link
Contributor

schmidsi commented Jun 3, 2023

+1 for package manager options, that being said, I think this is low priority.

@roninjin10
Copy link

Yarn2 supports pnpm. You can actually use yarn but tell yarn to use pnpm as the linker. All you gotta do is set nodeLinker to pnpm in the yarnrc config

@schmidsi
Copy link
Contributor

schmidsi commented Sep 11, 2023

Throwing this in here as it's the news of the weekend in the JavaScript bubble: Bun is stable: https://twitter.com/bunjavascript/status/1700148056706949627

Maybe consider using Bun instead of Yarn or PNPM? Although I expect issues with hardhat, rainbowkit, etc.

@roninjin10
Copy link

Bun is super bleeding edge and you get the odd segfault with no helpful error message from time to time still. But if you use only the package manager to install node modules and otherwise keep using node as the runtime it's a pretty solid choice. Anything is better than yarn

@carletex
Copy link
Member

Yarn has been working great for us since SE-1.

We have a PR for pnpm #444 almost ready to go, and we are thinking about it.

The only reason we decided to explore it was because of the individual lockfile per package (which is great for monorepos and avoids extra configuration on Vercel/etc). It will also help our CLI.

The release of Bun 1.0 also made me think, thanks @schmidsi for bringing it up! But It might be to early to consider... and also not sure if they support individual lockfiles! We'll keep an eye on it tho.

@technophile-04 technophile-04 linked a pull request Sep 12, 2023 that will close this issue
@carletex
Copy link
Member

Closing this for now. More info: #444

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting Can't start working on the issue (it has dependencies)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants