Make all options work

[bertfrees]

• All options defined in sbs:dtbook-to-pef should get a default value.
• Options that are not wanted should be deleted from sbs:dtbook-to-pef.
• Options that have been implemented in the generic dtbook-to-pef (see dtbook-to-pef.xpl and default.scss) should not be overwritten. For example, the default CSS should not contain the rule @page { size: 28 28 }. Instead provide default values for the options page-width and page-height.
• Options that were not generic enough to implement in the generic dtbook-to-pef should be implemented here. (This includes options that must be implemented in every agency script, such as show-braille-page-numbers and show-print-page-numbers, but also the options that are probably only useful for SBS and should therefore best be removed from the generic script: accented-letters, polite-forms, downshift-ordinal-numbers, etc..)
• Ideally all options, especially the ones implemented here, should be covered by unit tests.

[egli]

I cannot find any problems with the third issue about not overwriting generic options. In particular there is nothing in the default.scss about page size. A textual inspection doesn't reveal any other problems. So checking that problem off.

[bertfrees]

There is at least one issue:

pipeline-mod-sbs/src/main/resources/css/default.scss

Line 193 in 2913c1d

hyphens: auto; /* FIXME: don't hard-code, depends on param

[bertfrees]

I'm going to take over this issue from Christian.

Below is the complete list of options. I'll create a small test for each of them.

1. Implemented in the SBS specific dtbook-to-pef (or partly in generic script, partly in SBS script):

   • contraction-grade
   • document-identifier
   • footnotes-placement
   • include-production-notes
   • levels-in-footer
   • show-braille-page-numbers
   • show-print-page-numbers

2. To be implemented in the SBS specific dtbook-to-pef:

   • accented-letters
   • colophon-metadata-placement
   • downshift-ordinal-numbers
   • include-image-groups
   • include-note-references
   • left-margin
   • main-document-language
   • minimum-number-of-sheets
   • number-of-sheets
   • polite-forms
   • rear-cover-placement
   • tab-width
   • text-level-formatting

3. Implemented in the generic dtbook-to-pef:

   • ascii-file-format
   • capital-letters
     • also tested in mod-sbs
   • duplex
     • also tested in mod-sbs
   • force-braille-page-break
     • also tested in mod-sbs
   • hyphenation
     • also tested in mod-sbs
   • include-brf
   • include-captions
     • also tested in mod-sbs
   • include-images
     • also tested in mod-sbs
   • include-line-groups
     • also tested in mod-sbs
   • include-preview
   • line-spacing
     • also tested in mod-sbs
   • maximum-number-of-sheets
     • also tested in mod-sbs
   • page-height
     • also tested in mod-sbs
   • page-width
     • also tested in mod-sbs
   • stylesheet
   • toc-depth
     • also tested in mod-sbs

[bertfrees]

@egli You have checked the box above that says all options that are not wanted have been removed from sbs:dtbook-to-pef." Just want to double check that is true for these options:

• ascii-file-format
• left-margin
• capital-letters
• include-captions
• include-image-groups
• include-images
• include-line-groups
• include-note-references
• include-production-notes
• main-document-language
• rear-cover-placement
• tab-width
• text-level-formatting
• etc.

@mixa72