Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ABCpy package #3

Open
LoryPack opened this issue Jan 26, 2021 · 4 comments · May be fixed by #4
Open

Adding ABCpy package #3

LoryPack opened this issue Jan 26, 2021 · 4 comments · May be fixed by #4
Labels
enhancement New feature or request

Comments

@LoryPack
Copy link

Hello, thank you so much for creating this useful framework!

I am one of the mantainers of the ABCpy package (https://github.com/eth-cscs/abcpy); I would like to contribute by wrapping it for this benchmarking tool; in this way, some ABC algorithms which are not presently included in your analysis and are implemented in ABCpy could be included (see the README.md in the link above).

I am just opening this issue to let you know I'll try doing this, and asking if you have any suggestions for how to proceed in the best possible way. I think from your guidelines I need to create wrapping functions, so I'll try doing that and provide some updates if I encounter any problem.

@jan-matthis
Copy link
Contributor

jan-matthis commented Jan 27, 2021

Hi Lorenzo,

that's great! I'm much looking forward to have ABCpy part of the framework and will be glad to help on the way.

I would suggest modelling the integration after the existing run functions, e.g. take a look at how pyabcranger and/or pyabc are wrapped. Let me know of any questions or problems that show up on the way.

Best, Jan-Matthis

@jan-matthis jan-matthis linked a pull request Feb 1, 2021 that will close this issue
@jan-matthis jan-matthis added the enhancement New feature or request label Nov 15, 2021
@psteinb
Copy link
Contributor

psteinb commented May 12, 2022

Given #46 - it might be very useful to promote integrating abcpy rather soonish as the developer base appears to be large. thoughts?

@janfb
Copy link
Contributor

janfb commented Nov 20, 2024

Hi @LoryPack, it's been a while, but what is the status here? Are there still plans for doing this. Is there anything we could help with?

@LoryPack
Copy link
Author

Hi @janfb , thanks for pushing this up. Unfortunately, I am not maintainign ABCpy anymore. I add here @statrita2004 who is involved in the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging a pull request may close this issue.

4 participants