Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Association example wrong #145

Open
cannin opened this issue Nov 16, 2011 · 7 comments
Open

Association example wrong #145

cannin opened this issue Nov 16, 2011 · 7 comments

Comments

@cannin
Copy link
Contributor

cannin commented Nov 16, 2011

Spec L1 V1.3. In figure 2.37 the example are explicatory text are wrong. An association should only result in a multimer or complex. In the example given a process node should have been used to describe the aggregation of heme (or should that be haem) and globin to form the haemoglobin macromolecule. I propose we either remove the example or modify it to show the usage above.

Reported by: stumoodie

@cannin
Copy link
Contributor Author

cannin commented Nov 22, 2011

It is a fossil from the time before we restricted the output of an association to complex. I agree that the figure should be changed so that either:

  1. the first association is turned into a process, to show that an association cannot be used if the output is not a complex or a multimer
  2. the macromolecule is changed to a complex and the macromolecule multimer into a complex multimer.
    The text should be changed accordingly.

Regarding the spelling, it is either hemoglobin or h\ae{moglobin} but not haemoglobin.

Original comment by: lenov

@adrienrougny
Copy link
Collaborator

Still there in V2.0.

@hasanbalci
Copy link
Collaborator

@cannin In which direction should we move forward in this issue?

@hasanbalci
Copy link
Collaborator

Further discussion with editors: to be able to make this change we need to address complex and definition of association.

@adrienrougny
Copy link
Collaborator

adrienrougny commented Sep 3, 2024

Discussions at COMBINE: split the example in two:

  • hemoglobin (subunit->macromolecule)
  • p53 (subunit->multimer) (bonus: find an example where the subunit and multimer names are different: look into myosin II or dihydropyrimidase)

@adrienrougny adrienrougny added fixed-review-overleaf Issue fixed needs Overleaf review and removed fixed-review-overleaf Issue fixed needs Overleaf review labels Sep 3, 2024
@adrienrougny
Copy link
Collaborator

association_new_figure

@adrienrougny
Copy link
Collaborator

The examples above are now in the spec (p30-31), they should be checked, and the issue can be closed.

@adrienrougny adrienrougny added the fixed-review-overleaf Issue fixed needs Overleaf review label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants