Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "Positive Influence" with "Reduced Physical Stimulation" for the reduced notation #10

Open
amazein opened this issue Mar 12, 2021 · 2 comments

Comments

@amazein
Copy link

amazein commented Mar 12, 2021

I propose we replace “Positive Influence” (open arrowhead) link with “Reduced Physical Stimulation” (white arrowhead) in the outcome file because white arrowheads are in the original file in Newt, they correspond to SBGN (there is no open arrow there), there is no open arrow in SBGN.

To clarify: I use the reduced notation in CellDesigner as a way to have AF there and then in MINERVA, so, basically, we use PD shapes but connect them the way we do in AF.

Please see the images attached.

In Newt:

newt

In CellDesigner

cd

@amazein amazein closed this as completed Mar 12, 2021
@amazein amazein reopened this Mar 12, 2021
@amazein
Copy link
Author

amazein commented Mar 12, 2021

In Newt I used "Type: PD+AF" in map settings to enable mixed drawing and used PD "Macromolecule" shapes together with "Stimulation connectors", also from the PD palette, but connecting directly from macromolecule to macromolecule.

@amazein
Copy link
Author

amazein commented Mar 19, 2021

I think it would mean changing one line in the conversion code. For SBGN to CellDesigner direction, replace celldesigner:reactionTypePOSITIVE_INFLUENCE</celldesigner:reactionType> with
celldesigner:reactionTypeREDUCED_PHYSICAL_STIMULATION</celldesigner:reactionType> so it shows SBGN-like white arrowheads

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant