Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check balance/adjust balance #2

Open
sb- opened this issue Apr 7, 2014 · 2 comments
Open

Fix check balance/adjust balance #2

sb- opened this issue Apr 7, 2014 · 2 comments

Comments

@sb-
Copy link
Owner

sb- commented Apr 7, 2014

These do not take advantage of the config file, so the currencies are still hardcoded.

@ConradtJeff
Copy link

It appears there may be a bug in transaction processing related to balance calculations as well.
I've been working with this project for a few days now and in testing managed to produce sets of double-transactions which produced balances well above that actually stored in either wallet.
This is possibly due to the need for a redirect at the end of addorder, prevent people double posting via refresh.
return redirect(home_page(instrument, dismissable="Order placed successfully!"))
Additionally adding UNIQUE to transaction_id should help.
This should probably still be checked for however, when applying changes to account balances.
I'm still working on testing, and beginning the migrating everything over to config files for dynamic loading directly from the config.

If you would like to collaborate on this, please let me know, we intend on extensive development for the future of this project.

@sb-
Copy link
Owner Author

sb- commented Apr 13, 2014

I would love to collaborate. I think quite a bit of the SQL code needs to be overhauled, can you get on freenode IRC or jabber any time to discuss changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants