Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate away from skeleton AppShell #208

Open
joshuata opened this issue Nov 10, 2024 · 0 comments · May be fixed by #210
Open

Migrate away from skeleton AppShell #208

joshuata opened this issue Nov 10, 2024 · 0 comments · May be fixed by #210

Comments

@joshuata
Copy link

The skeleton AppShell component has been deprecated, and is responsible for many of the strange scrolling and navigation behaviors that have been reported including at least #183, #156, and #42 just from a quick check. This is because it scrolls only the main slot and not the full page. Skeleton themselves have a section in their documentation on why they have moved away from this solution: https://next.skeleton.dev/docs/get-started/layouts#using-body-scroll. Although this is for the upcoming release, the features to replace it are all just tailwind so it is all in place today.

In order to replace it we can start with the example for their two column layout. It should be a fairly quick swap, especially for someone with more css or tailwind experience than myself.

I'll start looking into the process myself, but any assistance would be welcome

joshuata added a commit to joshuata/smr-frontend that referenced this issue Nov 15, 2024
@joshuata joshuata linked a pull request Nov 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 New
Development

Successfully merging a pull request may close this issue.

1 participant