add code-path to allow AKS with byoCNI and cilium without kube-proxy #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hms-tkl
commented
Nov 22, 2023
hms-tkl
commented
- update main.tf file with helm-provider and release for cilium
- update main.tf file with kube-proxy configuration for cilium
- update variables.tf to account for byoCNI settings
- update modules/azure_aks/main.tf to account for byoCNI settings
- added byocni-values.yaml file for helm-configuration of cilium-1.14.4
- added kube-proxy.json file to allow enabling eBPF mode for byoCNI (aka. remove kube-proxy)
- added input-minimal.tfvars as an (semi-) working example
* update main.tf file with helm-provider and release for cilium * update main.tf file with kube-proxy configuration for cilium * update variables.tf to account for byoCNI settings * update modules/azure_aks/main.tf to account for byoCNI settings * added byocni-values.yaml file for helm-configuration of cilium-1.14.4 * added kube-proxy.json file to allow enabling eBPF mode for byoCNI (aka. remove kube-proxy) Signed-off-by: Tilo Kleßen <[email protected]>
|
Thank you for providing this PR with changes. This request needs to be further investigated. The code in PR needs to be redesigned to work well with the other existing CNI options currently present. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.