NodeJS run_
API method should return native JavaScript Promise
#932
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
run_
method, exposed through thedart.sass.js
file,returns a
Future
. TheFuture
object is not accessible due to theDart compilation process and
Future
not being a thing in theJavaScript/NodeJS platform.
In order to provide a better interface to the Sass API for
JavaScript/NodeJS consumers, a native
Promise
is now returned.Fixes bazelbuild/rules_sass#96.