Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract react json schema form carbon theme #803

Closed
burnettk opened this issue Dec 11, 2023 · 2 comments
Closed

extract react json schema form carbon theme #803

burnettk opened this issue Dec 11, 2023 · 2 comments
Labels
good first issue Good for newcomers

Comments

@burnettk
Copy link
Contributor

burnettk commented Dec 11, 2023

There are two open source libraries in the frontend that are related:

Since we decided to use carbon for our look and feel, we wanted our forms to also fit with this aesthetic. As such, we implemented a react json schema form "theme" to make our forms use carbon components and blend in with the rest of the site. We placed that theme in our codebase. However, react json schema form has themes inside of their codebase for various UI frameworks. It seems like this would be a more appropriate place for this code, and we might benefit from community-maintained upgrades to a greater extent. I asked if they would be willing to accept a pull request to add a theme for carbon, rjsf-team/react-jsonschema-form#3857. It seems like they might be willing to, but we should take them up on their offer to join their meeting and discuss it to make sure we don't waste a bunch of time. I thought of this since @Kayvon-Martinez 's first ticket was related to this area, and he did a good job on it.

It looks like the react json schema form community has been running with this to some extent:

@burnettk burnettk converted this from a draft issue Dec 11, 2023
@burnettk burnettk moved this from New Issue to Backlog in SpiffWorkflow Dec 11, 2023
@burnettk burnettk added this to the Status Sprint Tickets milestone Dec 11, 2023
@jasquat
Copy link
Contributor

jasquat commented Dec 11, 2023

NOTE: there are still a couple references to material-ui in the carbon theme. These would also have to be updated to use carbon.

They are the "RangeWidget" and "CheckboxesWidget". I'm not entirely sure how those get in used in rjsf.

@calexh-sar calexh-sar moved this from Backlog to New Issue in SpiffWorkflow Dec 11, 2023
@danfunk danfunk removed this from the Status Sprint Issues milestone Mar 12, 2024
@harmeet-status harmeet-status added the good first issue Good for newcomers label Mar 26, 2024
@burnettk
Copy link
Contributor Author

We don't intend to do this, since we are switching to MUI.

@github-project-automation github-project-automation bot moved this from New Issue to Resolved in SpiffWorkflow Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: Resolved
Development

No branches or pull requests

4 participants