Issue 907 - Checking for english locales #914
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pdate Automation: number outdated packages in requirements-workflow.txt
Merge pull request sap-linuxlab#908 from sap-linuxlab/dev
…g and setting Fixes issue sap-linuxlab#907. Signed-off-by: Bernd Finger <[email protected]>
added 3 commits
December 16, 2024 09:48
Klaas-
reviewed
Dec 16, 2024
| success_msg: "PASS: An English locale is installed." | ||
|
|
||
| - name: Get the current default locale | ||
| ansible.builtin.command: awk '/^LANG=/&&/en_/{print}' /etc/locale.conf |
There was a problem hiding this comment.
this does not take into account that C.UTF-8 is also english
There was a problem hiding this comment.
You are right. Although C is English it is not sufficient for HANA2 SPS08. The en_* locales have to be installed.
A test run showed that having the system locale C while having en_* installed was sufficient.
I am not sure how we can deal with it. For now I suggest accepting C and en_* locales, as long as en_* is installed. IIRC SAP recommends en_US.UTF-8, so if some body has a proof for that and put here or to the issue would be great. Then we could at least print a warning.
There was a problem hiding this comment.
@rhmk I just installed HANA SPS08 (rev 81) on RHEL 9.4 using:
-
control node:
LANGset toen_US.UTF-8in the shell which called theansible-playbookcommand
-
managed node:
LANG="C.UTF-8"in /etc/locale.conf- package
glibc-langpack-enbeing installed but not packagelangpacks-en. An attempt to remove the packageglibc-langpack-enfailed due to a dependency on the packagegrub2-tools-minimal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request checks that English locales are installed and set as the default. Additionally, a new variable allows for the enforcement of a specific English locale. This pull request is compatible with RHEL and SLES.