Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sap_vm_temp_vip: hardcoded group names #29

Open
rhmk opened this issue May 15, 2024 · 1 comment
Open

sap_vm_temp_vip: hardcoded group names #29

rhmk opened this issue May 15, 2024 · 1 comment

Comments

@rhmk
Copy link
Member

rhmk commented May 15, 2024

Currently, this role requires particular group names in the inventory. This needs to be more customized for generic use.

At least the group should be defined as a variable and can default to the now hardcoded names

Ideally, I would prefer a generic role to set a temp IP to "inventory hostname" or similar to get a more generic approach. Just pass current IP or Interface and virtual IP as parameters.

@sean-freeman
Copy link
Member

sean-freeman commented Jun 26, 2024

This is due the Ansible Role's genesis, where it was a part of the Ansible Playbooks for SAP project before requested split.

Likely this can be more easily solved by appending new var *_hostname. This would allow a user to specifically define, "this VIP on that HOST". Such as....

  when:
    - sap_vm_temp_vip_hana_primary is defined
    - inventory_hostname == sap_vm_temp_vip_hana_primary_hostname
    - not ansible_chassis_asset_tag == 'ibmcloud'

Change will have to wait until close to sap_infrastructure new release, and require immediate change to AP4S as it is a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants