Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Y24-473 - Extract and generalize multiple source_identifier filtering logic #1490

Open
seenanair opened this issue Nov 22, 2024 · 0 comments · May be fixed by #1508
Open

Y24-473 - Extract and generalize multiple source_identifier filtering logic #1490

seenanair opened this issue Nov 22, 2024 · 0 comments · May be fixed by #1508
Assignees
@seenanair
Labels
Size: S Small - low effort & risk Technical Debt Technical Debt Value: 3 Value to the insitute is average

Comments

@seenanair
Copy link
Contributor

seenanair commented Nov 22, 2024 •
edited
Loading

Describe the Housekeeping

The source_identifier filter logic currently implemented in the request_resource supports passing multiple values against a single field, enabling efficient matching of multiple barcodes in a single request and retrieving all records that match the valid barcodes.

traction-service/app/resources/v1/pacbio/request_resource.rb

Line 63 in 9df3648

filter :source_identifier, apply: lambda { |records, value, _options|

Extracting this logic from the request_resource and refactoring it into a shared utility or module will allow this functionality to be reused across all resources. This approach ensures consistency, reduces code duplication, and improves maintainability.

The extracted filter should be designed to be flexible, accommodating the specific requirements of each resource while maintaining a standardized approach to barcode filtering.

Blocking issues
Describe any other issues or tickets that may be blocking this change.

Additional context
#1488 (review)_
@psd-issuer psd-issuer bot changed the title Extract and generalize multiple barcode filtering logic from request_resource to a shared Module Y24-473 - Extract and generalize multiple barcode filtering logic from request_resource to a shared Module Nov 22, 2024
@seenanair seenanair added Technical Debt Technical Debt Traction and removed Traction labels Nov 22, 2024
@seenanair seenanair mentioned this issue Nov 22, 2024
Merged
@seenanair seenanair self-assigned this Dec 11, 2024
@seenanair seenanair added Size: S Small - low effort & risk Value: 3 Value to the insitute is average labels Dec 11, 2024
@seenanair seenanair changed the title Y24-473 - Extract and generalize multiple barcode filtering logic from request_resource to a shared Module Y24-473 - Extract and generalize multiple source_identifier filtering logic from request_resource to a shared Module Dec 11, 2024
@seenanair seenanair linked a pull request Dec 11, 2024 that will close this issue
Open
@seenanair seenanair changed the title Y24-473 - Extract and generalize multiple source_identifier filtering logic from request_resource to a shared Module Y24-473 - Extract and generalize multiple source_identifier filtering logic Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seenanair seenanair

Labels
Size: S Small - low effort & risk Technical Debt Technical Debt Value: 3 Value to the insitute is average
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Y24 -473 generalize multiple source identifier filtering logic sanger/traction-service
1 participant
@seenanair