Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Y24-308 - As developers we would like to Migrate existing library_type column on pacbio_request to an association as currently it is a text column which is less maintainable #1429

Open
4 tasks
Tracked by #701
JamesGlover opened this issue Mar 17, 2022 · 0 comments
Open
4 tasks
Tracked by #701

Y24-308 - As developers we would like to Migrate existing library_type column on pacbio_request to an association as currently it is a text column which is less maintainable #1429

JamesGlover opened this issue Mar 17, 2022 · 0 comments
Labels
Long Read Long Read Pacbio Size: M Medium - medium effort & risk Value: 2 Value to the insitute is low

Comments

@JamesGlover
Copy link
Contributor

JamesGlover commented Mar 17, 2022 •
edited by stevieing
Loading

As developers we would like to Migrate existing library_type column on pacbio_request to an association as currently it is a text column which is less maintainable

Acceptance criteria

  • Migrate existing library_type column on pacbio_request to an association
  • Update the setter for library type to look up via the table (And flag the request as invalid if the library type isn't found)
  • remove the library type text column on pacbio request
  • migrate existing records

Additional context
Probably needs a bit of research to check what work needs done in the ui
@JamesGlover JamesGlover mentioned this issue Mar 17, 2022
Closed
2 tasks
@JamesGlover JamesGlover changed the title Add Application column populated based on library type. We should get clarification if there is sufficient flexibility in SMRTLink to just let us pop the library type in there. Add Application column populated based on library type. [S=M,V=2] Mar 17, 2022
@stevieing stevieing changed the title Add Application column populated based on library type. [S=M,V=2] DPL-nnn - Add Application column populated based on library type. [S=M,V=2] Mar 17, 2022
JamesGlover referenced this issue Jun 15, 2022
Library types can be inactive, have external_identifiers
a8f0c94 
https://github.com/sanger/traction-service/issues/730 also
makes some requirements wrt library_type.
@stevieing stevieing changed the title DPL-nnn - Add Application column populated based on library type. [S=M,V=2] DPL-nnn - As developers we would like to Migrate existing library_type column on pacbio_request to an association as currently it is a text column which is less maintainable May 1, 2024
@stevieing stevieing added Size: M Medium - medium effort & risk Value: 2 Value to the insitute is low labels May 1, 2024
@stevieing stevieing transferred this issue from sanger/traction-service Sep 11, 2024
@psd-issuer psd-issuer bot changed the title DPL-nnn - As developers we would like to Migrate existing library_type column on pacbio_request to an association as currently it is a text column which is less maintainable Y24-308 - DPL-nnn - As developers we would like to Migrate existing library_type column on pacbio_request to an association as currently it is a text column which is less maintainable Sep 11, 2024
@stevieing stevieing changed the title Y24-308 - DPL-nnn - As developers we would like to Migrate existing library_type column on pacbio_request to an association as currently it is a text column which is less maintainable Y24-308 - As developers we would like to Migrate existing library_type column on pacbio_request to an association as currently it is a text column which is less maintainable Sep 11, 2024
@stevieing stevieing transferred this issue from sanger/traction-ui Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Long Read Long Read Pacbio Size: M Medium - medium effort & risk Value: 2 Value to the insitute is low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stevieing @JamesGlover