Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y24-160 - Update labware processor to facilitate retention instructions #121

Closed
4 tasks done
dasunpubudumal opened this issue Jun 24, 2024 · 1 comment · Fixed by #132, sanger/lab-share-lib#221, sanger/lab-share-lib#231 or #140
Assignees

Comments

@dasunpubudumal
Copy link
Contributor

dasunpubudumal commented Jun 24, 2024

User story
As developers, we need to facilitate sending retention instructions for labware (each tube/plate submitted) to mlwh by updating tol_lab_share/processors/create_labware_processor.py to support the retention_instruction field in the schema.

Who are the primary contacts for this story
Steve / Stuart / Dasun

Who is the nominated tester for UAT

Acceptance criteria
To be considered successful the solution must allow:

  • All messages received on the current message schema version are treated as implicitly specifying "Return to customer after 2 years" for the retention field.
  • All messages received on the new message schema version must contain retention_instruction field.
  • tol-lab-share should be able to process messages coming from either version of the schema.
  • Update lab-share-lib to allow validating the messages for a given list of schemas.

Dependencies
This story is blocked by the following dependencies:

References
This story has a non-blocking relationship with:

Additional context
Add any other context or screenshots about the feature request here.

@dasunpubudumal
Copy link
Contributor Author

dasunpubudumal commented Jul 25, 2024

Note: How does traction-service push messages to warehouse?

traction-service has got a sidecar broker (accessible via http://trac-uat.psd.sanger.ac.uk:15672/) that has the shovel plugin installed.

image

traction-service publishes messages to its own broker, which the shovel plugin delivers to the psd.sequencescape exchange in the warehouse which is bound to the queue psd.mlwh.multi-lims-warehouse-consumer (via a routing key). This will be consumed by warren and unified_warehouse and will persist the data in mlwh.

The overall process explained:

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment