Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPL-890-2 Replace webpack with Vite to ensure maintainability and security and enable us to upgrade to Vue 3 #260

Closed
2 tasks done
Sangeetha-Bheeman opened this issue Oct 2, 2023 · 1 comment · Fixed by #270 or #277
Assignees
Labels
size:s Small - low effort & risk Technical debt Technical Debt Update Aging Framework Dependencies OKR Update Aging Framework Dependencies OKR value:3 Value to the insitute is average Vue 3 Vue 3 upgrade

Comments

@Sangeetha-Bheeman
Copy link
Contributor

Sangeetha-Bheeman commented Oct 2, 2023

Describe the Housekeeping
As developers we need to upgrade Quanthub to Vue 3 as Vue 2 is out of support in December 2023. As part of this upgrade we need to remove webpack and replace it with Vite.

Who are the primary contacts for this story
Steve, Sangeetha

Who is the nominated tester for UAT
PSD

Acceptance criteria
To be considered successful the solution must allow.

  • Remove webpack and replace it with Vite
  • The application to continue to work as expected with no loss of service for users
@Sangeetha-Bheeman Sangeetha-Bheeman self-assigned this Oct 2, 2023
@Sangeetha-Bheeman Sangeetha-Bheeman added size:s Small - low effort & risk Technical debt Technical Debt value:3 Value to the insitute is average labels Oct 2, 2023
@Sangeetha-Bheeman Sangeetha-Bheeman added the Vue 3 Vue 3 upgrade label Oct 10, 2023
@Sangeetha-Bheeman
Copy link
Contributor Author

Sangeetha-Bheeman commented Oct 10, 2023

Tasks:

  • Remove webpack(Vue CLI - @vue/cli) dependencies from package.json

image

  • Remove vue-template-compiler from package.json
  • Remove babel dependencies from package.json

image

  • Remove babel.config.js
  • Remove babel from .eslintrc file
    • add.es2022: true to the node env
    • Update eslint and eslint vue plugin

      image
  • Install vite and vite-plugin-vue2
  • Add vite.config.js and make necessary changes
  • Move index.html from public to project root
    • Remove any template syntax like <%= BASE_URL %> and replace with absolute path
    • Include the javascript files like main.js
  • Update vue-cli-service scripts in package.json to vite specific commands
  • Update environment variables
    • Change process.env to use meta.env
    • Change variables with VUE_APP_ prefix to use VITE_
  • Ensure all imports of single file components end with the .vue extension
  • Testing:
    • Pass all the unit tests and e2e tests
    • Run the application and upload a quantfile and check if the qc dat is successfully exported to Sequencescape.
    • Check printing works
    • Pass CI and build release without errors


@SujitDey2022 SujitDey2022 added the Update Aging Framework Dependencies OKR Update Aging Framework Dependencies OKR label Oct 18, 2023
@Sangeetha-Bheeman Sangeetha-Bheeman changed the title DPL-890-2 Replace webpack with Vite DPL-890-2 Replace webpack with Vite to ensure maintainability and security and enable us to upgrade to Vue 3 Oct 20, 2023
@Sangeetha-Bheeman Sangeetha-Bheeman linked a pull request Nov 24, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:s Small - low effort & risk Technical debt Technical Debt Update Aging Framework Dependencies OKR Update Aging Framework Dependencies OKR value:3 Value to the insitute is average Vue 3 Vue 3 upgrade
Projects
None yet
2 participants