Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y24-502 - [BUG] Incorrect Warning Displayed in Limber for Active Submission Requests in scRNA LRC GEM-X 5p GEMs Input Plates #2110

Open
seenanair opened this issue Dec 6, 2024 · 2 comments
Labels
Bug Bug in code scRNA Size: M Medium - medium effort & risk Value: 3 Value to the insitute is average

Comments

@seenanair
Copy link
Contributor

seenanair commented Dec 6, 2024

Describe the bug

As part of the scRNA LRC GEM-X 5p GEMs input plate submission, the submission was successfully completed in SS, and the well has an active submission request. However, when viewing the plate in Limber, a warning is displayed:

"Submission (active) is not present for this labware. Any further work conducted from this plate may run into issues at the end of the pipeline."

Despite this warning, it does not prevent users from proceeding through the rest of the pipeline. In fact, users have been able to complete the entire pipeline process successfully.

RT Ticket Number
If applicable

To Reproduce
Steps to reproduce the behaviour:

  1. Create a sample manifest using template 'scRNA Core Pools Plate'
  2. Upload manifest with samples added to wells
  3. Build a Submission using order template 'Limber-Htp- scRNA Core cDNA Prep GEM-X 5p GEMs Input'
  4. Check the plate in Limber
  5. The following warning message will be displayed

Screenshot 2024-12-06 at 15 48 43

Expected behaviour

  • Limber should display warnings only when a submission request is genuinely missing or inactive for the specified labware.
    If a submission request is active and valid, no warning should appear.

  • To improve user experience, it would be helpful to display the request state by submission. This would better guide users in making informed decisions about whether to proceed with the pipeline.

@psd-issuer psd-issuer bot changed the title [BUG] Incorrect Warning Displayed in Limber for Active Submission Requests in scRNA LRC GEM-X 5p GEMs Input Plates Y24-502 - [BUG] Incorrect Warning Displayed in Limber for Active Submission Requests in scRNA LRC GEM-X 5p GEMs Input Plates Dec 6, 2024
@seenanair seenanair added Bug Bug in code scRNA Value: 3 Value to the insitute is average Size: S Small - low effort & risk Size: M Medium - medium effort & risk and removed Size: S Small - low effort & risk labels Dec 6, 2024
@andrewsparkes
Copy link
Member

andrewsparkes commented Dec 6, 2024

The green suggested action button is showing, suggesting the code that makes the determination for the next step is finding the right request type for this pipeline. Whereas the warning message showing suggests that code is filtering out the request for some reason.
Tom wondered why the code for those two things isn't shared at some level as they both interrogate what request is active.
This is an input/stock plate so treated differently in the code to an intermediate plate, so possibly the warning is something to do with that difference?

NB. Also fix the inconsistent config, in SS the GEMs Input plate is defined as cherrypickable target false whereas it is set to true in Limber.

@TWJW-SANGER
Copy link

TWJW-SANGER commented Dec 17, 2024

Just a note this issue #1167, seems like a similar problem where an incorrect warning is displayed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug in code scRNA Size: M Medium - medium effort & risk Value: 3 Value to the insitute is average
Projects
None yet
Development

No branches or pull requests

3 participants