Y24-396: Refactor Automatic State Changers #2044
Conversation
|
Will likely conflict with #2034, probably best to let that be merged in first, then refactor as required. |
|
|
||
| api.work_completion.create!(submissions: in_prog_submissions, target: v2_labware.uuid, user: user_uuid) | ||
| def labware | ||
| raise 'Tubes are not supported by API V1' |
There was a problem hiding this comment.
It's not a path that appears to be used in the current iteration - I'm hoping it will be removed with @sdjmchattie's v1 API removal changes
…nges-using-mixins
TODO: add tests for tube automated state changer
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## y24-088-tuberacks-epic #2044 +/- ##
==========================================================
+ Coverage 78.11% 78.54% +0.43%
==========================================================
Files 480 483 +3
Lines 18155 18554 +399
Branches 262 308 +46
==========================================================
+ Hits 14182 14574 +392
- Misses 3971 3978 +7
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| def v2_labware | ||
| @v2_labware ||= Sequencescape::Api::V2.tube_for_completion(labware_uuid) | ||
| @v2_labware ||= Sequencescape::Api::V2.tube_rack_for_completion(labware_uuid) | ||
| end | ||
|
|
||
| def labware |
There was a problem hiding this comment.
this labware vs v2_labware nonsense will hopefully get refactored out in a later story!
|
Further refactoring required after #2099 is merged in |
Closes #2002
Changes proposed in this pull request
contents_formethod ofDefaultStateChangerwhich was originally designed for plates and not tubesInstructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main]- Check story numbers included
- Check for debug code
- Check version