Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y24-375 scRNA - refactored shared constants to move them into a central config file #2050

Closed

Conversation

andrewsparkes
Copy link
Member

Closes #1983

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.20%. Comparing base (785f323) to head (1166fc6).
Report is 131 commits behind head on develop.

Files with missing lines Patch % Lines
...s/validators/required_number_of_cells_validator.rb 60.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2050      +/-   ##
===========================================
+ Coverage    77.91%   78.20%   +0.28%     
===========================================
  Files          463      471       +8     
  Lines        17720    18226     +506     
  Branches       225      262      +37     
===========================================
+ Hits         13807    14253     +446     
- Misses        3911     3971      +60     
  Partials         2        2              
Flag Coverage Δ
javascript 70.43% <ø> (+0.83%) ⬆️
pull_request 77.97% <71.42%> (+0.05%) ⬆️
push 77.90% <71.42%> (-0.02%) ⬇️
ruby 91.13% <71.42%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewsparkes
Copy link
Member Author

andrewsparkes commented Nov 7, 2024

@KatyTaylor
I think the idea is to remove the current functionality that allows a study override for required_number_of_cells_per_sample_in_pool.
This would mean this validator is no longer required: app/models/validators/required_number_of_cells_validator.rb
In this PR I have just removed usage of the override in the export files. Removal of the validator should be another small story I think. It's intertwined with the presenter code so not straight forward.

@andrewsparkes andrewsparkes self-assigned this Nov 7, 2024
Copy link
Contributor

@KatyTaylor KatyTaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of comments but only tiny things. You've got a test failing (haven't looked into it).

Copy link
Contributor

@KatyTaylor KatyTaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from failing test

@andrewsparkes
Copy link
Member Author

Closing as already included in epic, see PR here #2069

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Y24-375 - File downloads improvements for MVP
2 participants