-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Y24-375 scRNA - refactored shared constants to move them into a central config file #2050
Y24-375 scRNA - refactored shared constants to move them into a central config file #2050
Conversation
…rride of required_number_of_cells_per_sample_in_pool in export files
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2050 +/- ##
===========================================
+ Coverage 77.91% 78.20% +0.28%
===========================================
Files 463 471 +8
Lines 17720 18226 +506
Branches 225 262 +37
===========================================
+ Hits 13807 14253 +446
- Misses 3911 3971 +60
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…ew override from pool well polymetadata
@KatyTaylor |
… and added error check for poly metadata
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of comments but only tiny things. You've got a test failing (haven't looked into it).
Co-authored-by: KatyTaylor <[email protected]>
Co-authored-by: KatyTaylor <[email protected]>
Co-authored-by: KatyTaylor <[email protected]>
Co-authored-by: KatyTaylor <[email protected]>
Co-authored-by: KatyTaylor <[email protected]>
Co-authored-by: KatyTaylor <[email protected]>
Co-authored-by: KatyTaylor <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good apart from failing test
Closing as already included in epic, see PR here #2069 |
Closes #1983