Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test case for subworkflow with different module remotes #2

Closed
jvfe opened this issue Jun 21, 2024 · 1 comment · Fixed by #6
Closed

Add test case for subworkflow with different module remotes #2

jvfe opened this issue Jun 21, 2024 · 1 comment · Fixed by #6
Assignees
@jvfe
Labels
testing/linting Issue related to the tests or the linting functions
Milestone
Reproducible erro...

Comments

@jvfe
Copy link
Collaborator

jvfe commented Jun 21, 2024

Add a new test case under subworkflows/install that attempts to download a subworkflow with cross-repository modules, so as to have an automated and clear functionality goal. This should be done prior to work on the actual implementation.
@jvfe jvfe self-assigned this Jun 21, 2024
@jvfe jvfe converted this from a draft issue Jun 21, 2024
@jvfe jvfe added the testing/linting Issue related to the tests or the linting functions label Jun 21, 2024
jvfe added a commit that referenced this issue Jun 21, 2024
@jvfe
tests: Add test case for cross-organization subwf
9825d89 
Strangely it is passing at the moment, it seems the install command
returns a passing exit code regardless of installing all modules.

- Addresses #2
@jvfe jvfe mentioned this issue Jun 21, 2024
Merged
4 tasks
@jvfe jvfe linked a pull request Jun 21, 2024 that will close this issue
tests: Add test case for cross-organization subwf #6
Merged
4 tasks
@jvfe jvfe added this to the Reproducible error example milestone Jun 21, 2024
@jvfe jvfe pinned this issue Jun 23, 2024
@jvfe
Copy link
Collaborator Author

jvfe commented Jul 29, 2024

Done in #6

@jvfe jvfe closed this as completed Jul 29, 2024
@jvfe jvfe unpinned this issue Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jvfe jvfe

Labels
testing/linting Issue related to the tests or the linting functions
Projects
nf-core module & sub-workflow sharing across organizations
Status: Done
Milestone
Reproducible error example
Development

Successfully merging a pull request may close this issue.

tests: Add test case for cross-organization subwf sanger-tol/nf-core-tools
1 participant
@jvfe