Skip to content
This repository has been archived by the owner on Jun 15, 2023. It is now read-only.

Gpl 568 ui for log errors #15

Merged
merged 10 commits into from
Aug 3, 2020
Merged

Gpl 568 ui for log errors #15

merged 10 commits into from
Aug 3, 2020

Conversation

KatyTaylor
Copy link
Contributor

No description provided.

harrietc52 and others added 10 commits July 30, 2020 12:45
…gination

- 'lighthouse' repo change was needed to allow max_results to go up this high
- there are only around 365 records at the moment and only a few added daily, so will take a while to reach the limit
- TODO: order by date descending in the API call, so it doesn't matter if we hit the limit, we still see the latest records?
- needed to switch from using the provider method in the table to using created() function to get the pagination to work, as it was setting rows() after loading the table
- add a bullet point for each error
- realised we had this checkbox hanging around from copy-paste from another page
…o GPL-568-ui-for-log-errors

# Conflicts:
#	test/modules/api.spec.js
@codecov
Copy link

codecov bot commented Jul 31, 2020

Codecov Report

Merging #15 into develop will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop       #15   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         4    +1     
  Lines           78       101   +23     
  Branches         6         7    +1     
=========================================
+ Hits            78       101   +23     
Impacted Files Coverage Δ
pages/imports.vue 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42125b3...8784351. Read the comment docs.

@KatyTaylor KatyTaylor marked this pull request as ready for review August 3, 2020 10:41
@KatyTaylor KatyTaylor merged commit 4c70d17 into develop Aug 3, 2020
@KatyTaylor KatyTaylor linked an issue Aug 3, 2020 that may be closed by this pull request
@pjvv pjvv deleted the GPL-568-ui-for-log-errors branch February 5, 2021 13:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GPL-568b error page to view import logs #63
2 participants