Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSO Not Working #2

Open
jonahbron opened this issue May 5, 2014 · 3 comments
Open

SSO Not Working #2

jonahbron opened this issue May 5, 2014 · 3 comments

Comments

@jonahbron
Copy link

I'm using Single-Sign-On with the disqus_rails gem, and have it configured properly, but the Disqus thread still shows as though the user is logged-out. I've whitelisted the proper domains in my Disqus account, added debugged the encoded and encrypted data that the gem produces (and it's valid), but the thread still doesn't show up correctly. Any idea on what might be the problem?

@sandric
Copy link
Owner

sandric commented May 16, 2014

Don't really know what's the issue is.. Its a little bit problematic for me to test it - I just tried to check whether sso is working on my newly created disqus site and it seems all good. Have you tried it - https://disqus.com/api/sso/ ? Is there you user you want to display with you in-site credentials in sso 'users' list? Have he logged in with login sso button? May be the problem is in instance variable where gem tries to get data? I will try to create some test db user model next day and try it out on heroku.. Can't really say what's wrong all I remember that when I was writing gem sso was feature in testing to deploy soon so there is a good probability smth got broken..

@sushil10018
Copy link

Hey guys, is the problem with sso still persisting? I can't get it implemented as suggested in wiki.

@sushil10018
Copy link

As mentioned in the documentation here: https://help.disqus.com/customer/portal/articles/236206-integrating-single-sign-on#configure-domain

this.sso = {
      name:   "SampleNews",
      button:  "http://example.com/images/samplenews.gif",
      icon:     "http://example.com/favicon.png",
      url:        "http://example.com/login/",
      logout:  "http://example.com/logout/",
      width:   "800",
      height:  "400"
};

But, it seems that in our case, within disqus_rails.js.coffee:37 the value was set as

this.sso = that.sso
# where the value seems to be 'true' only instead of key value pair.

I'm still digging through the issue, will hopefully try a pull-request once the issue gets fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants