Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added mass for AC model #33

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

cmichelenstrofer
Copy link
Member

Adds added mass effects to the Actuator Cylinder aerodynamic model.

@cmichelenstrofer cmichelenstrofer self-assigned this Oct 29, 2024
@kevmoor
Copy link
Collaborator

kevmoor commented Nov 1, 2024

Please pull in recent changes from master branch, noting the updated variable names for added mass and buoyancy. Also, the equations should go directly into the AC radialforce() function, which is essentially equivalent to the DMS streamtube() function. More details on the high level tracking issue #32

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 30.30303% with 23 lines in your changes missing coverage. Please review.

Project coverage is 80.57%. Comparing base (8fb7ab2) to head (6aaa2d3).

Files with missing lines Patch % Lines
src/vawt-ac/src/acmultiple.jl 30.30% 23 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
- Coverage   82.10%   80.57%   -1.54%     
==========================================
  Files           7        7              
  Lines        1196     1220      +24     
==========================================
+ Hits          982      983       +1     
- Misses        214      237      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants