Fix Missing / Incorrect Licenses

[jrconway3]

So after discussing things over with MedicineStorm I figured out that a lot of licenses here are outdated. MedicineStorm went out and requested OGA-BY licenses back in 2022 for a lot of different assets related to LPC (I know I got one of those requests, too).

The following added the OGA-BY license:

1. All LPC Assets Created by Sharm
2. All LPC Assets Created by Redshrike
3. All LPC Assets Created by Makrohn
4. All LPC Assets Created by Nilla122
5. All LPC Assets Created by Wulax
6. MadMarcel's Orcs and Pirates
7. Joe White's Hairstyles: https://opengameart.org/content/ponytail-and-plain-hairstyles

The biggest question here comes in the form of derivatives. If another user modified an asset and that was updated to be OGA-BY, do we need to keep that derivative license? How many changes are required to consider it derivative enough?

At the very least, if the original asset is not OGA-BY we shouldn't include that license.

Missing Licenses:

Some licenses are also missing entirely and the original asset seemingly cannot be found.

1. waistband (torso/waist/waistband)
2. long_center_part (hair/long_center_part)

What we can do here is search the history and see when these were first added to the repo. That's not easy, but there is a way to check a single asset and figure out the history of that one asset. Interestingly, long_center_part has the wrong list of palettes, too; it appears to be an older palette list and not the current standard hair palettes.

At first I thought long_center_part was a variant of long_straight, but I'm pretty sure its not anymore.

Incorrect Attribution:

Some assets seem to have incorrect attribution. I think this may be a result of basing an asset on an entire submission, even if the specific asset has different credits individually.

Formal Pants:
Bluecarrot16's Gentlemen includes Formal Shirts and Formal Pants, among other assets:
https://opengameart.org/content/lpc-gentleman

This heavily involves a lot of assets from Pennomi and Laetissima's "2 Characters":
https://opengameart.org/content/lpc-2-characters

In the credits.csv it also mentions Wulax's asset:
https://opengameart.org/content/lpc-medieval-fantasy-character-sprites

However, the original LPC Gentlemen doesn't reference Wulax at all. Furthermore, the Pants in "2 Characters" are not credited to Pennomi and Laetissima, they did the other assets, but not the Pants specifically. The Pants are identical to Redshrike's original pants:
https://opengameart.org/content/liberated-pixel-cup-lpc-base-assets-sprites-map-tiles

So I believe the Formal Pants should only credit Redshrike and Bluecarrot16. I added new frames recently, though, that should also add myself and ElizaWy.

[jrconway3]

I left this comment on that issue above, but I'd rather keep it here.

So I fixed many OGA-BY licenses by following up with MedicineStorm and reviewing the list above. I went through line-by-line and checked the original entries, many of which have in fact been updated to OGA-BY.

Some I had to question whether to add them or not. For example, bluecarrot16 often posts big lists of re-releases and I'm not sure how modified these assets are in there. If bluecarrot16 mentioned that the asset was heavily modified, I opted not to update the license. If bluecarrot isn't credited at all, even if one of these lists was included, I decided to include the OGA-BY for sure. Other instances were hit or miss, so I was trying to be cautious about whether including it or not.

As far as I can tell, Manuel Riecke did most of the original haistyles except Princess (done by Sharm). Manuel Riecke has not been confirmed to have approved OGA-BY 3.0 to my knowledge, so I didn't include any of his assets. Sharm, Redshrike, Wulax, Mad Marcel, Nilla122, Makrohn, and Joe White have a good chunk of updates in here, though, and as such, this added a lot of OGA-BY licenses.

I also fixed the attribution on "parted" hairstyle; this was Manuel Riecke and I simply cleaned up two of the "down" animation poses.

Please let me know if I made any mistakes by adding an OGA-BY license where it should not have gone, but I tried to be very careful with this one.

Even though the above PR was merged I noticed this issue was not closed. Probably a good idea so we can still have others double-check and confirm the licenses updates are accurate and perhaps add any more, too.

[jrconway3]

I'll gradually start listing new entries I find that are fringe cases, such as Nilla122's braided hair:
hair/braid/female/blonde.png: by Nila122, ElizaWy. License(s): CC-BY-SA 3.0, GPL 3.0, GPL 2.0
https://opengameart.org/content/3-hairs-for-lpc

While this is primarily credited to Nilla122 and ElizaWy it was re-released and modified by bluecarrot16. I feel like this is a case where it can be updated to OGA-BY even though OGA-BY is not listed on bluecarrot16's entry:
https://opengameart.org/content/lpc-hair

If any more fringe cases like this are seen that weren't updated, we can list them here and they can gradually get updated.

[jrconway3]

Updated this to include Waistband and center_long_part which are missing credits from licensing-handling, as well as the licenses from #228. If we find other assets that have missing or broken licenses they should be noted here.

If they're not fixed, the reason is because we're still unsure at this point exactly what licenses should be handled.

[jrconway3]

long_center_part is here:
https://opengameart.org/content/lpc-hair

In the credits:

| long_center_part         | thecilekli, bluecarrot16                                        | CC0                              | touchup                           | https://opengameart.org/content/lpc-long-straight-hair-with-12-colors

Not sure why the credit is missing in credits.csv. Maybe it was a screwup on my part and I accidentally deleted it.

I'll check the history for waistband and see if I can come up for anything as to why that's missing and who added it.

[jrconway3]

The weird thing though is that long_center_part doesn't appear to match that entry. However, it did appear that the head/bangs portion was similar, so perhaps the rest of the hairstyle is Bluecarrot's addition to clean it up a bit. Either way, though, those are the correct credits.

[jrconway3]

Waistband is Sara. So it should have the same credits as Sara Tunic. I think Bluecarrot simply split this off of the tunic.

[jrconway3]

New credits:

hair/long_center_part,,"thecilekli, bluecarrot16",CC0,https://opengameart.org/content/lpc-long-straight-hair-with-12-colors,https://opengameart.org/content/lpc-hair,,,,,,,,,,,,,,OK
torso/waist/waistband,"LPC Sara by Redshrike, contributed by William Thompsonj, Waistband Separated by Bluecarrot16","Bluecarrot16, Mandi Paugh, Stephen Challener (Redshrike), William.Thompsonj",OGA-BY 3.0,http://opengameart.org/content/sara-wizard,https://opengameart.org/content/lpc-sara,,,,,,,,,,,,,,OK

[jrconway3]

Here's the comparison:
https://github.com/sanderfrenken/Universal-LPC-Spritesheet-Character-Generator/compare/license-handling...jrconway3:Universal-LPC-Spritesheet-Character-Generator:license-handling-issue-142-fixes?expand=1

[jrconway3]

New issue to replace this one:
LiberatedPixelCup#39