-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest angular 4 #55
Comments
Hi Sam, this is a great little implementation of using cucumber with angular. I have been plaing around with it the last few days and it works like a charm (I'm new to cucumber and it's a relevation!!). I have integrated your source into an angular cli project using angular 4, latest web pack, latest protractor and locked the package versions down using Yarn. |
Hi there @Fiontan, About ng4 and cli.. for me it's even better if we could integrate this with CLI.. I would like to have the 2 approaches tough.. Running the Cucumber E2E test should be totally independent of the webpack config and the Angular application |
Please provide a plan of updates and work if you'd like to contribute, I will be available for help and feedback :) |
HI @samvloeberghs , I have uploaded your source and my changes to bitbucket and will forward a link presently. The tests are run the same either by issuing the 'ng e2e' command or simply 'protractor' from teh command line- the result is the same regardless. Isthat what you mean regarding ' Running the Cucumber E2E test should be totally independent of the webpack config and the Angular application'? If so it's already good to go... |
@samvloeberghs please see your gmail inbox for an invitation to the bitbucket repo. |
Seems to be working nice.. Could you be interested in updating this project to incorporate your changes here? |
@samvloeberghs regrading your comment #48 do you want to proceed? I noticed an issue on saturday with the register specs- they don't seem to run completely after my upgrade so perhaps some further investigation is merited. |
@Fiontan can we take the discussion of github? contact me on google hangouts or skype ( sam.vloeberghs ) |
We should update our code to angular 4
The text was updated successfully, but these errors were encountered: