Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for s3 inputs for FfmpegAdapter and PassThroughAdapter #133

Open
cjcolvar opened this issue Feb 1, 2024 · 0 comments
Open

Add tests for s3 inputs for FfmpegAdapter and PassThroughAdapter #133

cjcolvar opened this issue Feb 1, 2024 · 0 comments

Comments

@cjcolvar
Copy link
Member

cjcolvar commented Feb 1, 2024 •
edited
Loading

The tests for the FfmpegAdapter and PassThroughAdapter are only for file input urls but these adapters can also handle s3 input urls. There should be tests that exercise the special handling for s3 urls.

It might be good to setup a docker environment with minio running to test these without mocking all of the web interactions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cjcolvar