Add Annotation Support

[cryptiklemur]

Would be really cool to specify breadcrumbs via annotations :)

Idk if this makes sense to you, but a discussion would be nice

[richsage]

Sorry for the late reply - I'd definitely be up for that :-)

[cryptiklemur]

heh, is this your subtle way of asking for a PR?

[richsage]

PRs are always welcome :-)

[MatissJanis]

Just a heads up - annotation support would be really cool, if someone is up to building it. ;)

[soullivaneuh]

👍 I could take a look if I get some time.

[soullivaneuh]

@aequasi @richsage @MatissJanis Have you annotation configuration samples of what you are wondering?

[bocharsky-bw]

@soullivaneuh Sounds great, I think it will be nice to have such behaviour like:

use WhiteOctober\BreadcrumbsBundle\Annotation\BreadcrumbsAnnotation as Breadcrumb;

/**
 * @Breadcrumb\Item('Home', url='/')
 * @Breadcrumb\RouteItem('Blog', route={name='post'})
 */
class PostController() {
    /**
     * @Breadcrumb\RouteItem('{post.name}', route={name='post_show', parameters={'id': '{post.id}'}})
     */
    public function showAction(Post $post)
    {
        // action code here...
    }
}

in result we will have:

Home > Blog > The post name

What do you think?

[cryptiklemur]

A single annotation would probably be easier

/**
 * @Breadcrumb('Home', url='/')
 * @Breadcrumb('Blog', route={name='post'})
 */
class PostController() {
    /**
     * @Breadcrumb('{post.name}', route={name='post_show', parameters={'id': '{post.id}'}})
     */
    public function showAction(Post $post)
    {
        // action code here...
    }
}

[richsage]

I'd probably prefer @aequasi's version - a single annotation. Unless it gets a bit too unwieldy with large amounts of configuration options in the annotation. @bocharsky-bw what were your thoughts behind separate ones (aside from the URL and route differences)?

[bocharsky-bw]

@richsage I have maintained the current application architecture only. We have addItem and addRouteItem methods now. If we do a single annotation for it, we also could to prioritize url or route if user add them both inadvertently.

I think a single annotation is a bit overload, but @aequasi is right, it will be more easy to use and most probably it will be better in this case.

[soullivaneuh]

Both approach has good argument. I prefer @aequasi too. I'll try it and see if it's possible.

[soullivaneuh]

Using expression language may help. Dunno, just a remember note.

http://symfony.com/doc/current/components/expression_language/introduction.html

[bocharsky-bw]

@soullivaneuh I think symfony's expression language will be useful in this case 👍
Even more it provides by Symfony SE out-of-the-box.

[rvanlaak]

Found the Abhoryo/APYBreadcrumbTrailBundle having Annotation support, maybe @Abhoryo can tell or that bundle still is maintained? It does exactly what #35 (comment) does suggest.

Especially the integration with @ParamConverter is really awesome! https://github.com/Abhoryo/APYBreadcrumbTrailBundle/blob/master/Resources/doc/annotation_configuration.md#title-using-paramconverter

[rzymianin11]

appreciate to do this! :)