Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved fingerprint handling #9

Open
samcday opened this issue May 25, 2024 · 5 comments
Open

Improved fingerprint handling #9

samcday opened this issue May 25, 2024 · 5 comments
Labels
needs-upstream-changes Changes to libphosh are required
Milestone

Comments

@samcday
Copy link
Owner

samcday commented May 25, 2024

Do something nicer when greetd gives us the "waiting for fingerprint" info message.

@samcday
Copy link
Owner Author

samcday commented May 27, 2024

Do fprint messages just show on the session bus somewhere?

If so, could write a simple listener that shows a fingerprint icon in the top bar when fingerprint verification is in progress.

@samcday
Copy link
Owner Author

samcday commented Aug 26, 2024

I followed this up further upstream as well: https://gitlab.gnome.org/World/Phosh/phosh/-/issues/1070

I think the visual improvements could be interesting to prototype in phrog, and if they come out nicely maybe it is something that could head upstream and find utility elsewhere. We'll see.

I do think that the best approach to handling the fingerprint UX through greetd conversation is by using extra signalling from the fprint dbus interface. If a signal that a fingerprint scan took place is seen, we can progress the conversation at that point.

@samcday samcday changed the title Fingerprint visual cue Improved fingerprint handling Aug 26, 2024
@samcday
Copy link
Owner Author

samcday commented Aug 30, 2024

This depends on #37

@samcday
Copy link
Owner Author

samcday commented Sep 6, 2024

3b9456d improves things a bit already, I had some silly code to delay the greetd responses to info/error messages by 1 second. Sending the response immediately makes the fingerprint auth flow quite snappy.

The visual UX improvements detailed in the upstream ticket are still worthwhile.

@samcday samcday added the needs-upstream-changes Changes to libphosh are required label Sep 7, 2024
@samcday samcday added this to the v0.43.0 milestone Sep 7, 2024
@samcday
Copy link
Owner Author

samcday commented Sep 7, 2024

Tentatively aiming this at 0.43.0. For now, the recent commit makes things quite usable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-upstream-changes Changes to libphosh are required
Projects
None yet
Development

No branches or pull requests

1 participant