Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import configuration with libsmbconf API #46

Open
phlogistonjohn opened this issue Jun 16, 2022 · 1 comment
Open

Import configuration with libsmbconf API #46

phlogistonjohn opened this issue Jun 16, 2022 · 1 comment
Assignees

Comments

@phlogistonjohn
Copy link
Collaborator

Currently, when sambacc imports samba configuration from it's own JSON based fomat it uses the net conf import command line. Future versions of Samba will have a python binding for the smbconf library. This library can be used to read a text based config (smb.conf) or read/write registry based configuration. This would allow us to use the library directly rather than generating a text based configuration and shelling out to net command to update the registry.

It may also make post-init configuration updates simpler and easier to see exactly what is changing.

@phlogistonjohn
Copy link
Collaborator Author

This is partially implemented as PR #85 brought in smbconf support to help parse smb.conf text files in the AD DC case. I started looking into this but found that the registry.tdb reference in samba is a singleton that is only loaded once per process. This makes adding unit tests to match netcmd_loader a bit more challenging. However, that only impacts the unit tests so this is looking doable soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant