Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store sent messages #62

Open
dbrgn opened this issue Nov 8, 2016 · 6 comments
Open

Store sent messages #62

dbrgn opened this issue Nov 8, 2016 · 6 comments

Comments

@dbrgn
Copy link
Member

dbrgn commented Nov 8, 2016

...so that when logging a send-error message, we actually know which message was lost.

@dbrgn dbrgn added the feature label Nov 8, 2016
@lgrahl
Copy link
Member

lgrahl commented Nov 8, 2016

I'd only do that in debug mode though.

@dbrgn dbrgn added feature and removed feature labels Dec 5, 2016
@dbrgn dbrgn added the question label Dec 5, 2016
@lgrahl
Copy link
Member

lgrahl commented Dec 5, 2016

I think it should be active in debug mode only.

@dbrgn
Copy link
Member Author

dbrgn commented Dec 5, 2016

Reason? Performance?

@lgrahl
Copy link
Member

lgrahl commented Dec 5, 2016

No, I just want to be cautious when giving out detailed error reasons. Think of the padding oracle attack on SSL.

@lgrahl
Copy link
Member

lgrahl commented Dec 13, 2016

I misinterpreted this thread's topic (dunno why). Sure, logging these messages should be fine.

What I was referring to was WebSocket close code reasons.

@dbrgn dbrgn modified the milestone: 1.x Release Feb 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants