-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store sent messages #62
Comments
I'd only do that in debug mode though. |
@lgrahl the Java version implements that currently:
Do you think it should be removed? |
I think it should be active in debug mode only. |
Reason? Performance? |
No, I just want to be cautious when giving out detailed error reasons. Think of the padding oracle attack on SSL. |
I misinterpreted this thread's topic (dunno why). Sure, logging these messages should be fine. What I was referring to was WebSocket close code reasons. |
...so that when logging a send-error message, we actually know which message was lost.
The text was updated successfully, but these errors were encountered: