-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embroider with staticComponents: true not working with pods components #160
Comments
After spending some time spiking out different possible approaches for this, it seems as though it's likely possible to partially support That may still be something we pursue in the future, but right now I suspect that effort would be better invested in working with @Turbo87 and @ef4 on figuring out the necessary v2 addon APIs Embroider would need to expose to support |
@dfreeman I'd love to hear about some of the API's embroider would need to expose. Would embroider need to change significantly to make it work? |
@dfreeman I was looking at how next.js does module CSS and it looks like they don't use something like After we have template imports, we can do something identical. Until then, we can do something similar I think: import styles from "./styles.css"
export default class Component {
styles = styles
} <div class={{this.styles.myClassName}}>This is a styled div</div> I think the code above works already. If we referenced the styles that way instead of usingn |
Reproduction here: https://github.com/danwenzel/embroider-issues/tree/css-modules
I've got the beta embroider version of ember-css-modules installed (1.3.0-beta.1). When turning on the
staticComponents: true
embroider option, ember-css-modules cannot seem to find thestyles.css
file within a pods component folder:If I turn off
staticComponents: true
it works. It also works with components in the classic folder structure, even ifstaticComponents: true
is on.The text was updated successfully, but these errors were encountered: