Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cant get blank tag-annotation-template to work #14

Open
meisnate12 opened this issue Sep 21, 2021 · 0 comments
Open

Cant get blank tag-annotation-template to work #14

meisnate12 opened this issue Sep 21, 2021 · 0 comments

Comments

@meisnate12
Copy link

meisnate12 commented Sep 21, 2021

I have tag-annotation-template: '' and it is just ignored and the default is used. I know im doing it right because if i have anything in the string it works.

let annotationTemplate = getInput('tag-annotation-template') || 'Released version {VERSION}';

this line is whats causing the problem when getInput('tag-annotation-template') is blank its considered false and just defaults to
Released version {VERSION} so there's no way to not have an annotation

my current workaround is to just use v1.0.3 which doesn't have annotations at all
uses: salsify/[email protected]

personally i think you should just change it to

let annotationTemplate = getInput('tag-annotation-template') || '';

and let the default operation have no annotation and let users add an annotation if they want by specifying tag-annotation-template

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant