Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup coding standards #161

Open
AlexSkrypnyk opened this issue May 27, 2023 · 1 comment
Open

Cleanup coding standards #161

AlexSkrypnyk opened this issue May 27, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@AlexSkrypnyk
Copy link
Contributor

The project uses mixed coding standards:

  • some files have an indentation of 2 spaces, some 4
  • vertical spacing is not followed consistently
  • comments formatting is not followed consistently
  • CI does not not scan tests dir

Is it possible to utilise Drupal or Symfony2 standard for this project (having a completely custom standard with 49 rules is a bit hard to follow :) ).

I'm happy to put a PR together to get this sorted.
@steveworley
Copy link
Contributor

Agreed, I think it makes sense to standardise on the Symfony2 standards.

@steveworley steveworley added enhancement New feature or request good first issue Good for newcomers labels Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AlexSkrypnyk @steveworley