[QCDP24-26] show the datarequest created by current user after user moved to diff org #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awset
force-pushed
the
feature/QCDP24-26-org
branch
from
9ed3e8d to
37b21a6
Compare
MarkCalvert
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://salsadigital.atlassian.net/browse/QCDP24-26
the AC says, the facet will be the user's orgs, which mean it should be the
requesting_organisationfield instead oforganization_id, the last PR was mentioning the other way around (and it was not fully tested yet)the
organization_idfield is populated by default from the dataset id, which it can be not the current users org. so the facet ideally should be therequesting_organisationfield.now there will be an issue when user edit the data request, by default, the
organization_idis hidden, andrequesting_organisationis a list of current user's org, if user moved org, and try to edit the older data request from older org, the older org won't be visible on the list, and user can't save this data request edit form without selecting the available org list. and if user select the available org, the older org from the facet will be gone, because the data request is belongs to otherrequesting_organisationI think we should have a quick discussion to align if this approach are right or not.