[QCDP24-31] removed close datarequest button #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkCalvert
approved these changes
Sep 9, 2024
| @@ -112,7 +112,8 @@ def delete_datarequest(context, data_dict): | |||
|
|
|||
|
|
|||
| def close_datarequest(context, data_dict): | |||
| return auth_if_creator(context, data_dict, constants.SHOW_DATAREQUEST) | |||
| # Close data request feature is removed in this project. | |||
There was a problem hiding this comment.
FYI CKAN does not check auth functions for sysadmin users and automatically returns true because they have access to everything.
Sysadmin users will be able to use the API to close a data request.
To prevent sysadmin users from being automatically authorised add the decorate auth_sysadmins_check
…m being automatically authorised
MarkCalvert
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://salsadigital.atlassian.net/browse/QCDP24-31