-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate IMP.Restraint and PMI restraint classes #211
Comments
@benmwebb I'm considering implementing more general forms of |
Sure, PMI is for high-level modeling, not a dumping ground for random classes. It sounds like |
This unary function will permit, for example, multi-well harmonic potentials. Added to generalize `IMP.pmi.restraints.basic.BiStableDistanceRestraint`. Relates salilab/pmi#211
This unary function permits the calculation of the weighted sum of negative exponential of multiple unary functions, useful when the output of the functions is a score, -log(p). Added to generalize `IMP.pmi.restraints.basic.BiStableDistanceRestraint`. Relates salilab/pmi#211
`BiStableDistanceRestraint` inherited `IMP.Restraint` and was not a PMI-style restraint. A general NStableDistanceRestraint that inherits the new PMI restraint base class was created, and BiStableDistanceRestraint inherits that class. Relates salilab#211, salilab#156
In general, PMI restraints are wrappers around and not children of
IMP.Restraint
. There are a few children ofIMP.Restraint
which are not PMI restraints (they do not implement, e.g.get_output()
). However, two classes,TorqueRestraint
andCylinderRestraint
, inheritIMP.Restraint
but implement PMI restraint methods. In the interest of having a unified PMI restraint base class, a pureIMP.Restraint
version of these should be implemented and then wrapped as with other PMI restraint classes.The text was updated successfully, but these errors were encountered: