Create PendingInteraction model after configuration #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorkravchenko
requested review from
EgorovEI,
rasmustautsglia and
ykyivskyi-gl
ykyivskyi-gl
approved these changes
Dec 12, 2024
| @@ -29,6 +30,14 @@ extension SecureConversations { | |||
| hasPending || unreadCount > 0 | |||
| } | |||
| .assign(to: &$hasPendingInteraction) | |||
|
|
|||
| if self.pendingStatusCancellationToken == nil { | |||
| print("Unable to subscribe to pending status updates") | |||
There was a problem hiding this comment.
should we use log instead of print?
There was a problem hiding this comment.
It seems to me that this has to be a part of SDK configuration and affect SDK configuration completion result. So instead of adding logs I added error handling 047da93.
rasmustautsglia
approved these changes
Dec 12, 2024
EgorovEI
approved these changes
Dec 12, 2024
igorkravchenko
requested review from
ykyivskyi-gl,
EgorovEI and
rasmustautsglia
EgorovEI
reviewed
Dec 12, 2024
GliaWidgets/SecureConversations/SecureConversations.PendingInteraction.swift
Show resolved
Hide resolved
rasmustautsglia
approved these changes
Dec 12, 2024
ykyivskyi-gl
approved these changes
Dec 12, 2024
|
!squash |
Make sure PendingInteraction model is created after configuration to prevent subscription for unread message count and pending SC status from failure, because 'pubsub' is created only when Core SDK is configured. MOB-3871
sm-deployer
force-pushed
the
fix/MOB-3871-hasPendingInteraction-is-not-updated
branch
from
047da93 to
dbf8da4
Compare
igorkravchenko
merged commit 76c87b1
into
feature/entry-widget-and-secure-conversations-v2
8 checks passed
igorkravchenko
deleted the
fix/MOB-3871-hasPendingInteraction-is-not-updated
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure PendingInteraction model is created after configuration to prevent subscription for unread message count and pending SC status from failure, because 'pubsub' is created only when Core SDK is configured.
MOB-3871
What was solved?
Release notes:
Additional info:
Screenshots: