Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoopDetection bug #150

Closed
wattanakorn495 opened this issue Oct 5, 2024 · 1 comment
Closed

LoopDetection bug #150

wattanakorn495 opened this issue Oct 5, 2024 · 1 comment

Comments

@wattanakorn495
Copy link

Datatype should be double

int loop_distance_thr = odometry_length * 0.03;

double loop_distance_thr = odometry_length * 0.03;

and Should scale factor 0.03 be in config file?

@xukuanHIT
Copy link
Collaborator

@wattanakorn495 Hi, thank you for pointing out this bug; we have already fixed it. There are many parameters in the code, and we only provided a good initial value, which can indeed be modified based on the actual scenario. We are also considering adding them to the configuration file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants