Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Dialog should wait for PIN entry window(s) #480

Open
nephros opened this issue Dec 15, 2024 · 1 comment
Open

[Bug] Dialog should wait for PIN entry window(s) #480

nephros opened this issue Dec 15, 2024 · 1 comment
Labels
bug something that needs fixing

Comments

@nephros
Copy link
Contributor

nephros commented Dec 15, 2024

SailfishOS VERSION: 4.x, 5.0, likely all

HARDWARE: Sony Xperia 10 iii, Jolla C2, likely any

PATCHMANAGER VERSION: 3.2.11


BUG DESCRIPTION

See https://forum.sailfishos.org/t/sim-pin-remaining-attempt-count-may-be-wrong/21409

After initial boot, Patchmanager should probably wait for both the Lock Code as well as any SIM PIN entry dialogs before starting its "apply all active patches" countdown.

@nephros nephros added the bug something that needs fixing label Dec 15, 2024
@Olf0
Copy link
Contributor

Olf0 commented Dec 16, 2024

As you asked there:

To fix this on the Patchmanager side: is there a way to detect from an application that the SIM PIN dialog is active currently??

Provided that the SIM PIN dialogue is started by a systemd unit, one may query if that unit is currently active. But it depends on the implementation if such a unit just triggers the dialogue or stays active until the dialogue is closed.
Side note: AFAIU this dialogue may appear at any time, although in practise it is usually displayed before the "Launcher" is started, this is nothing one should rely on AFAIU. Consequently simply delaying the start of Patchmanager (e.g. until the "Launcher" is fully up) does not resolve this issue reliably.

After all, this issue is clearly a bug in the current implementation of the SIM PIN dialogue, as it does not query the number of remaining tries from the SIM card, but uses its own. independent counter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something that needs fixing
Projects
None yet
Development

No branches or pull requests

2 participants