Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] in functions install and remove the patch success prevent to make the patch backup #446

Open
robang74 opened this issue Jul 2, 2023 · 4 comments
Labels
bug something that needs fixing

Comments

@robang74
Copy link

robang74 commented Jul 2, 2023

SailFish OS version: 4.5.0.9
Patchmanger Version: 3.2.9
Hardware: Xperia 10 II

BUG DESCRIPTION

In these two functions remove_text_patch() and install_text_patch() the exit 0 in success() prevents that the backup of the installed/removed patch can be managed correctly.

STEPS TO REPRODUCE

It is in the code - it is about the flow logic.

ADDITIONAL INFORMATION

Please check this commit:

The code is different because it refers the unified version of pm_apply and pm_unapply but it is the logic that matters.

@robang74 robang74 added the bug something that needs fixing label Jul 2, 2023
@CODeRUS
Copy link
Contributor

CODeRUS commented Jul 21, 2023

Please take care to fix the code issues reported by this person, but create your own changes. no commits authored by this person are allowed to be merged in this repo.

@CODeRUS
Copy link
Contributor

CODeRUS commented Jul 21, 2023

@nephros @nephros @Olf0 fyi

@Olf0
Copy link
Contributor

Olf0 commented Jul 22, 2023

@b100dian was missed.

@Olf0
Copy link
Contributor

Olf0 commented Jul 22, 2023

Please let us carry out this meta-discussion at the oldest bug report filed by robang74: #444

Every thing discussed there an the meta-level is sure applicable to the filed issues #445 and #446, too (plus any future ones by robang74).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something that needs fixing
Projects
None yet
Development

No branches or pull requests

3 participants