Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to restart additional services, e.g., profiled #320

Open
wetab73 opened this issue Oct 3, 2022 · 3 comments
Open

Ability to restart additional services, e.g., profiled #320

wetab73 opened this issue Oct 3, 2022 · 3 comments
Labels
backends daemon, systemd and dbus components feature request feature requests, suggestions, ideas etc. infrastructure building, packaging, hosting etc.

Comments

@wetab73
Copy link

wetab73 commented Oct 3, 2022

Patchmanager is currently able to restart only a very limited number of services. Please consider supporting more services that can be restarted, e.g. profiled (systemctl --user restart profiled).

I recently made a patch adding support for a custom profile (and a quick toggle button to easily switch it on/off) which creates an ini file in /etc/profiled/ containing definition of that custom profile for profiled. Unfortunately, it gets created by Patchmanager only after profiled has already been started, so it requires a profiled restart. Sadly, Patchmanager can't do it, so it'd have to be done manually after each reboot, which is a no-go.

So the suggestion is to enhance Patchmanager to support restarting more services (e.g. via adding corresponding categories).

@wetab73 wetab73 added the feature request feature requests, suggestions, ideas etc. label Oct 3, 2022
@Olf0 Olf0 changed the title Ability to restart additional services like e.g. profiled Ability to restart additional services, e.g., profiled Oct 3, 2022
@nephros
Copy link
Contributor

nephros commented Oct 4, 2022

#31 requests something similar.

As mentioned there, even though the future-proof solution would be for patch authors to be able to specify services to be restarted, with PM running as root that is not a good solution.

Therefore I think this should be evaluated on a case-by-case (i.e. per service) basis (but can be implemented in a batch).

Also some user services may not be a good idea to restart (?).

profiled and ngfd are fine though I think.

Requires:

  • define new metadata categories
  • implement Web Catalog handling of new categories
  • implement Patchmanager daemon handling of new categories
  • update documentation

(I don't think the UI needs any changes but would have to check.)

@nephros nephros added backends daemon, systemd and dbus components infrastructure building, packaging, hosting etc. labels Oct 4, 2022
@nephros
Copy link
Contributor

nephros commented Oct 4, 2022

Question: should we mash profiled and ngfd in a single category ("ui-feedback" or so)?

@nephros
Copy link
Contributor

nephros commented Oct 4, 2022

Unfortunately, it gets created by Patchmanager only after profiled has already been started, so it requires a profiled restart.

Just as a workaround, you could implement a service restart via dbus in a main.qml file shipped with the patch.

Example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backends daemon, systemd and dbus components feature request feature requests, suggestions, ideas etc. infrastructure building, packaging, hosting etc.
Projects
None yet
Development

No branches or pull requests

2 participants