Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] PM confused about state of applied patch #184

Open
nephros opened this issue Nov 5, 2021 · 0 comments
Open

[BUG] PM confused about state of applied patch #184

nephros opened this issue Nov 5, 2021 · 0 comments
Labels
backends daemon, systemd and dbus components bug something that needs fixing patching related to activating, deactivating and handling Patches

Comments

@nephros
Copy link
Contributor

nephros commented Nov 5, 2021

SailfishOS VERSION (Settings → About product → Build): 4.2

HARDWARE (Settings → About product → Manufacturer & Product name): Xperia 10 DS

PATCHMANAGER VERSION (Settings → Patchmanager → [Top pulley] About): 3.1

BUG DESCRIPTION

PM sometimes can not apply a patch because it is already applied, but PM doesn't realize it. So in effect it trips over its own preload trick.

STEPS TO REPRODUCE

  1. download and apply a patch which needs "restart services" (<-- is that last part required? unclear)
  2. apply that patch via PM, restart e.g. lipstick
  3. unapply that patch, don't "restart services
  4. close PM
  5. update patchmanager to a different version/rpm
  6. try to apply that same patch (it shows as unapplied, although on the system it is applied still)

--> patch applying fails, as the target files are already patched

ADDITIONAL INFORMATION

Not 100% sure this is how to trigger it.

It sometimes happens while I multi-task patch development and PM development. (So I both edit patches on the fly, and update development versions of PM itself).

But it's some combination of unapplying, updating either the patch source itself or PM, and restarts.

@nephros nephros added the bug something that needs fixing label Nov 5, 2021
@nephros nephros changed the title [BUG] [BUG] PM confused about state of applied patch Nov 6, 2021
@nephros nephros added backends daemon, systemd and dbus components patching related to activating, deactivating and handling Patches labels Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backends daemon, systemd and dbus components bug something that needs fixing patching related to activating, deactivating and handling Patches
Projects
None yet
Development

No branches or pull requests

1 participant